Note in --verbose help that the extra output may include sensitive data - #8205
Draft
isaacroldan wants to merge 2 commits into
Draft
Note in --verbose help that the extra output may include sensitive data#8205isaacroldan wants to merge 2 commits into
isaacroldan wants to merge 2 commits into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
July 31, 2026 11:37
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
July 31, 2026 11:38
7da8e51 to
c592b60
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
July 31, 2026 11:38
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
July 31, 2026 11:41
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
July 31, 2026 11:42
c592b60 to
60924b8
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
July 31, 2026 11:42
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
July 31, 2026 12:07
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
July 31, 2026 12:08
298f7e7 to
6d850a6
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
July 31, 2026 12:08
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
July 31, 2026 14:04
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
July 31, 2026 14:04
6d850a6 to
4ce3af0
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
July 31, 2026 14:04
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
July 31, 2026 14:54
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
July 31, 2026 14:54
4ce3af0 to
d47f121
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
July 31, 2026 14:54
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
July 31, 2026 15:25
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
July 31, 2026 15:25
d47f121 to
512c5af
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
July 31, 2026 15:25
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
July 31, 2026 15:47
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
July 31, 2026 15:47
512c5af to
7d3c98d
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
July 31, 2026 15:47
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
July 31, 2026 15:50
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
July 31, 2026 15:50
7d3c98d to
51d7ec3
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
July 31, 2026 15:50
isaacroldan
force-pushed
the
analytics-redact-shopify-env
branch
from
August 3, 2026 11:35
4eb005e to
be539ad
Compare
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
August 3, 2026 11:35
51d7ec3 to
4a448ee
Compare
Redaction is best effort, so the flag that turns on the payload dump should say so. Regenerates the manifests, README and dev docs that embed the description.
isaacroldan
changed the base branch from
analytics-redact-shopify-env
to
graphite-base/8205
August 3, 2026 11:41
isaacroldan
force-pushed
the
verbose-flag-sensitive-data-note
branch
from
August 3, 2026 11:41
4a448ee to
5f117c6
Compare
isaacroldan
changed the base branch from
graphite-base/8205
to
analytics-redact-shopify-env
August 3, 2026 11:42
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/private/node/analytics/redact-output.d.ts/**
* Redacts the copy of the analytics payload that gets printed.
*
* The payload itself is already sanitized for Monorail. This is the extra pass for
* the `outputDebug` sinks that `--verbose` turns on, where the audience is a
* terminal and whatever scrapes it rather than a sensitive Monorail field.
*
* `key` is the whole reason this exists. It marks a credential in the environment
* -- SHOPIFY_PROXY_KEY holds a signed token, SHOPIFY_FLAG_GRAPHIQL_KEY is derived
* from the app secret -- but `api_key` is an app's public client ID that Monorail
* is meant to receive, so the payload rules leave the name alone.
*
* @param payload - The already-sanitized analytics payload.
* @returns A copy with the values of `key`-named entries replaced.
*/
export declare function redactForOutput<T>(payload: T): T;
Existing type declarationsWe found no diffs with existing type declarations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Redaction of the analytics payload is best effort (see #8198, which this stacks on), so the flag that turns the payload dump on should say as much.
WHAT is this pull request doing?
One clause added to the
--verbosedescription inpublic/node/cli.ts:The rest of the diff is regeneration. The description is embedded once per command in the manifests, the CLI README and the dev docs data, and
tests-pr.ymlfails if any of them are stale, sopnpm refresh-manifestsandpnpm build-dev-docsaccount for ~520 of the lines here.How to test your changes?
The
--verboseline shows the added sentence.Checklist
patch) and added a changeset🤖 Generated with Claude Code